oca/oca-purchase
2
0
Fork 0
mirror of https://github.com/bringout/oca-purchase.git synced 2026-04-21 06:42:02 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

purchase_advance_payment: use self.order_id instead of active_ids context

Browse source 
Fix make_advance_payment to use the order_id stored on the wizard
instead of relying on active_ids from context, which can be lost
or point to wrong PO after wizard reopens.
Also fix partner_id to use PO partner directly instead of commercial_partner_id.

🤖 assisted by claude
This commit is contained in:
Ernad Husremovic 2026-02-11 11:21:14 +01:00
parent a3f2664ee8
commit 5222b93391
1 changed files with 3 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
odoo-bringout-oca-purchase-workflow-purchase_advance_payment/purchase_advance_payment/wizard/purchase_advance_payment_wizard.py
View file

@ -142,7 +142,7 @@ class AccountVoucherWizardPurchase(models.TransientModel):
self.currency_amount = amount_advance self.currency_amount = amount_advance
def _prepare_payment_vals(self, purchase): def _prepare_payment_vals(self, purchase):
partner_id = purchase.partner_id.commercial_partner_id.id partner_id = purchase.partner_id.id
return { return {
"purchase_id": purchase.id, "purchase_id": purchase.id,
"date": self.date, "date": self.date,
@ -183,13 +183,9 @@ class AccountVoucherWizardPurchase(models.TransientModel):
if self.journal_currency_id.compare_amounts(self.amount_advance, 0.0) <= 0: if self.journal_currency_id.compare_amounts(self.amount_advance, 0.0) <= 0:
raise exceptions.ValidationError(_("Amount of advance must be positive.")) raise exceptions.ValidationError(_("Amount of advance must be positive."))
payment_obj = self.env["account.payment"] payment_obj = self.env["account.payment"]
purchase_obj = self.env["purchase.order"]
purchase_ids = self.env.context.get("active_ids", []) if self.order_id:
if purchase_ids: payment_vals = self._prepare_payment_vals(self.order_id)
purchase_id = fields.first(purchase_ids)
purchase = purchase_obj.browse(purchase_id)
payment_vals = self._prepare_payment_vals(purchase)
payment = payment_obj.create(payment_vals) payment = payment_obj.create(payment_vals)
if bool( if bool(
self.env["ir.config_parameter"] self.env["ir.config_parameter"]