19.0 vanilla

odoo-bringout-oca-ocb-hr_skills/hr_skills/models/hr_skill_level.py

@@ -2,52 +2,44 @@
 # Part of Odoo. See LICENSE file for full copyright and licensing details.
 
 from odoo import api, fields, models, _
-from odoo.exceptions import ValidationError
 
 
-class SkillLevel(models.Model):
+class HrSkillLevel(models.Model):
     _name = 'hr.skill.level'
     _description = "Skill Level"
-    _order = "level_progress desc"
+    _order = "level_progress"
 
-    skill_type_id = fields.Many2one('hr.skill.type', ondelete='cascade')
+    skill_type_id = fields.Many2one('hr.skill.type', index='btree_not_null', ondelete='cascade')
     name = fields.Char(required=True)
     level_progress = fields.Integer(string="Progress", help="Progress from zero knowledge (0%) to fully mastered (100%).")
     default_level = fields.Boolean(help="If checked, this level will be the default one selected when choosing this skill.")
 
-    _sql_constraints = [
-        ('check_level_progress', 'CHECK(level_progress BETWEEN 0 AND 100)', "Progress should be a number between 0 and 100."),
-    ]
+    # This field is a technical field, created to be set exclusively by the front-end; it's why this computed field is
+    # not stored and not readonly.
+    # With this field, it's possible to know in onchange defined in the model hr_skill_type which
+    # level became the new default_level.
+    technical_is_new_default = fields.Boolean(compute="_compute_technical_is_new_default", readonly=False)
 
-    def name_get(self):
-        if not self._context.get('from_skill_level_dropdown'):
-            return super().name_get()
-        return [(record.id, f"{record.name} ({record.level_progress}%)") for record in self]
+    _check_level_progress = models.Constraint(
+        'CHECK(level_progress BETWEEN 0 AND 100)',
+        'Progress should be a number between 0 and 100.',
+    )
+
+    # This compute is never trigger by a depends in purpose. The front-end will change this value when the
+    # default_level will become true.
+    def _compute_technical_is_new_default(self):
+        self.technical_is_new_default = False
 
     @api.model_create_multi
     def create(self, vals_list):
-        levels = super().create(vals_list)
-        levels.skill_type_id._set_default_level()
-        return levels
+        skill_levels = super().create(vals_list)
+        for level in skill_levels:
+            if level.default_level:
+                level.skill_type_id.skill_level_ids.filtered(lambda r: r.id != level.id).default_level = False
+        return skill_levels
 
-    def write(self, values):
-        levels = super().write(values)
-        self.skill_type_id._set_default_level()
-        return levels
-
-    def unlink(self):
-        skill_types = self.skill_type_id
-        res = super().unlink()
-        skill_types._set_default_level()
+    def write(self, vals):
+        res = super().write(vals)
+        if vals.get('default_level'):
+            self.skill_type_id.skill_level_ids.filtered(lambda r: r.id != self.id).default_level = False
         return res
-
-    @api.constrains('default_level', 'skill_type_id')
-    def _constrains_default_level(self):
-        for skill_type in set(self.mapped('skill_type_id')):
-            if len(skill_type.skill_level_ids.filtered('default_level')) > 1:
-                raise ValidationError(_('Only one default level is allowed per skill type.'))
-
-    def action_set_default(self):
-        self.ensure_one()
-        self.skill_type_id.skill_level_ids.with_context(no_skill_level_check=True).default_level = False
-        self.default_level = True