19.0 vanilla

odoo-bringout-oca-ocb-account/account/tests/test_product.py

@@ -1,37 +1,131 @@
-from .common import AccountTestInvoicingCommon
-from odoo.tests.common import Form, tagged, new_test_user
+# -*- coding: utf-8 -*-
+
+from odoo.addons.account.tests.common import AccountTestInvoicingCommon
 from odoo import Command
+from odoo.tests import Form, tagged
+from odoo.tests.common import new_test_user
 
 
-@tagged("post_install", "-at_install")
-class AccountProductCase(AccountTestInvoicingCommon):
+@tagged('post_install', 'post_install_l10n', '-at_install')
+class TestProduct(AccountTestInvoicingCommon):
+
     @classmethod
-    def setUpClass(cls, chart_template_ref=None):
-        super().setUpClass(chart_template_ref)
+    def setUpClass(cls):
+        super().setUpClass()
         cls.internal_user = new_test_user(
-            cls.env, login="internal_user", groups="base.group_user"
+            cls.env,
+            login="internal_user",
+            groups="base.group_user",
+        )
+        cls.account_manager_user = new_test_user(
+            cls.env,
+            login="account_manager_user",
+            groups="account.group_account_manager",
         )
 
     def test_internal_user_can_read_product_with_tax_and_tags(self):
         """Internal users need read access to products, no matter their taxes."""
         # Add a tag to product_a's default tax
-        self.company_data["company"].country_id = self.env.ref("base.us")
-        tax_line_tag = self.env["account.account.tag"].create(
-            {
-                "name": "Tax tag",
-                "applicability": "taxes",
-                "country_id": self.company_data["company"].country_id.id,
-            }
-        )
-        repartition_lines = (
-            self.product_a.taxes_id.invoice_repartition_line_ids
-            | self.product_a.taxes_id.refund_repartition_line_ids
-        ).filtered_domain([("repartition_type", "=", "tax")])
-        repartition_lines.write({"tag_ids": [Command.link(tax_line_tag.id)]})
+        tax_line_tag = self.env["account.account.tag"].create({
+            "name": "Tax tag",
+            "applicability": "taxes",
+        })
+        self.product_a.taxes_id.repartition_line_ids.tag_ids = tax_line_tag
         # Check that internal user can read product_a
-        with Form(
-            self.product_a.with_user(self.internal_user).with_context(lang="en_US")
-        ) as form_a:
+        self.env.invalidate_all()
+        with Form(self.product_a.with_user(self.internal_user)) as form_a:
             # The tax string itself is not very important here; we just check
             # it has a value and we can read it, so there were no access errors
             self.assertTrue(form_a.tax_string)
+
+    def test_multi_company_product_tax(self):
+        """ Ensure default taxes are set for all companies on products with no company set. """
+        product_without_company = self.env['product.template'].with_context(allowed_company_ids=self.env.company.ids).create({
+            'name': 'Product Without a Company',
+        })
+        product_with_company = self.env['product.template'].with_context(allowed_company_ids=self.env.company.ids).create({
+            'name': 'Product With a Company',
+            'company_id': self.company_data['company'].id,
+        })
+        companies = self.env['res.company'].sudo().search([])
+        # Product should have all the default taxes of the other companies.
+        self.assertRecordValues(product_without_company.sudo(), [{
+            'taxes_id': companies.account_sale_tax_id.ids,
+            'supplier_taxes_id': companies.account_purchase_tax_id.ids,
+        }])  # Take care that inactive default taxes won't be shown on the product
+        # Product should have only the default tax of the company it belongs to.
+        self.assertRecordValues(product_with_company.sudo(), [{
+            'taxes_id': self.company_data['company'].account_sale_tax_id.ids,
+            'supplier_taxes_id': self.company_data['company'].account_purchase_tax_id.ids,
+        }])
+
+    def test_product_tax_with_company_and_branch(self):
+        """Ensure that setting a tax on a product overrides the default tax of branch companies.
+            as branches share taxes with their parent company."""
+        parent_company = self.env.company
+        # Create a branch company and set a default sales tax.
+        self.env['res.company'].create({
+            'name': 'Branch Company',
+            'parent_id': parent_company.id,
+            'account_sale_tax_id': parent_company.account_sale_tax_id.id,
+        })
+
+        tax_new = self.env['account.tax'].create({
+            'name': "tax_new",
+            'amount_type': 'percent',
+            'amount': 21.0,
+            'type_tax_use': 'sale',
+        })
+
+        # Create a product in the parent company and set its sales tax to the new tax
+        product = self.env['product.template'].with_context(allowed_company_ids=[parent_company.id]).create({
+            'name': 'Product with new Tax',
+            'taxes_id': tax_new.ids,
+        })
+
+        self.assertEqual(product.taxes_id, tax_new, "The branch company default tax shouldn't be set if we set a different tax on the product from the parent company.")
+
+    def test_product_category_parent_account_fallback(self):
+        """When no account is set on a product category, accounts should be inherited from parent categories.
+        Also covers the case where income and expense are defined at different hierarchy levels.
+        """
+        grandparent_income = self.copy_account(self.company_data['default_account_revenue'])
+        child_expense = self.copy_account(self.company_data['default_account_expense'])
+
+        grandparent_categ = self.env['product.category'].create({
+            'name': 'Grandparent Category',
+            'property_account_income_categ_id': grandparent_income.id,
+        })
+        parent_categ = self.env['product.category'].create({
+            'name': 'Parent Category',
+            'parent_id': grandparent_categ.id,
+            'property_account_income_categ_id': False,
+            'property_account_expense_categ_id': False,
+        })
+        child_categ = self.env['product.category'].create({
+            'name': 'Child Category',
+            'parent_id': parent_categ.id,
+            'property_account_income_categ_id': False,
+            'property_account_expense_categ_id': child_expense.id,
+        })
+        product = self.env['product.product'].create({
+            'name': 'Test Product',
+            'categ_id': child_categ.id,
+        })
+
+        invoice, bill = self.env['account.move'].create([
+            {
+                'move_type': 'out_invoice',
+                'partner_id': self.partner_a.id,
+                'invoice_line_ids': [Command.create({'product_id': product.id})],
+            },
+            {
+                'move_type': 'in_invoice',
+                'partner_id': self.partner_a.id,
+                'invoice_line_ids': [Command.create({'product_id': product.id})],
+            },
+        ])
+        self.assertEqual(invoice.invoice_line_ids.account_id, grandparent_income,
+            "Customer invoice line should use grandparent category's income account")
+        self.assertEqual(bill.invoice_line_ids.account_id, child_expense,
+            "Vendor bill line should use child category's expense account")