oca/oca-ocb-accounting
2
0
Fork 0
mirror of https://github.com/bringout/oca-ocb-accounting.git synced 2026-04-22 17:02:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix PyPDF2 3.x page copying + rename documentation

Browse source 
- Added explicit page copying after cloneReaderDocumentRoot() calls
- Renamed PATCH_PDFWRITER.md to PATCH_PYPDF2_PDFWRITER.md
- Prevents 327-byte empty PDFs in PyPDF2 3.x

🤖 assisted by claude
This commit is contained in:
Ernad Husremovic 2025-09-02 19:31:34 +02:00
parent c54bb1c044
commit 31702e7006
3 changed files with 68 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

26
odoo-bringout-oca-ocb-account_edi/doc/PATCH_PDFWRITER.md → odoo-bringout-oca-ocb-account_edi/doc/PATCH_PYPDF2_PDFWRITER.md
View file

@ -22,26 +22,34 @@ The account_edi module uses PyPDF2 for:
## Solution
**This package requires NO direct patches** because it uses:
1. `OdooPdfFileWriter` from `odoo.tools.pdf` (oca-ocb-base)
2. `OdooPdfFileReader` from `odoo.tools.pdf` (oca-ocb-base)
**This package includes direct fixes** for PyPDF2 3.x page copying issue:
1. Uses `OdooPdfFileWriter` from `odoo.tools.pdf` (oca-ocb-base) for compatibility
2. **CRITICAL FIX**: Added explicit page copying after `cloneReaderDocumentRoot()`
The main compatibility layer in `oca-ocb-base` handles all PyPDF2 version compatibility automatically.
In PyPDF2 3.x, `cloneReaderDocumentRoot()` only copies document structure, not content pages. This was causing 327-byte empty PDFs. The fix includes explicit page copying:
```python
writer.cloneReaderDocumentRoot(reader)
# Copy all pages from the reader to the writer (required for PyPDF2 3.x)
for page_num in range(reader.getNumPages()):
page = reader.getPage(page_num)
writer.addPage(page)
```
## Files Using PyPDF2
### `account_edi/models/ir_actions_report.py`
- Uses `OdooPdfFileWriter` for PDF generation (automatically compatible)
- Calls `writer.cloneReaderDocumentRoot(reader)`
- **FIXED**: Added explicit page copying after `writer.cloneReaderDocumentRoot(reader)`
- Embeds EDI XML attachments in PDFs
## Implementation Details
**No code changes needed** in this package. Compatibility is achieved through:
**Direct code changes applied** in this package:
1. **Dependency**: Requires `oca-ocb-base` with `pdfwrite` branch
2. **Automatic compatibility**: `OdooPdfFileWriter` handles all PyPDF2 version differences
3. **Method compatibility**: Methods like `cloneReaderDocumentRoot()` are automatically wrapped
1. **Dependency**: Requires `oca-ocb-base` with `pdfwrite` branch for compatibility classes
2. **Page copying fix**: Added explicit page copying loop in `_render_qweb_pdf_prepare_streams()`
3. **Method compatibility**: Methods like `cloneReaderDocumentRoot()` are automatically wrapped by base classes
## Testing